test: add v5 regression coverage and fix widget access recursion - #176
Merged
Conversation
Cover nwidart v13 facade usage, module macros, Resource PHP 8.4 compatibility, and CanAccessTrait behavior, and stop delegating to package parent classes that re-enter the trait with the wrong module name. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…rsion Normalize mixed directory separators in path macros and convertPathToNamespace so Windows CI and runtime resolve module provider namespaces correctly. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modulefacade (no global alias), module path macros,ResourcePHP 8.4/Pint compatibility, andCanAccessTraitwidget accessCanAccessTraitso widgetcanView()no longer recurses throughCoolsam\Modules\ChartWidgetand looks up the wrong module name (modulesinstead ofblog)convertPathToNamespace()on Windows so provider namespaces resolve correctlyCreatesTestModuleshelper and testbenchModulesdirectory cleanup between runsIssues
Closes #106
Closes #162
Relates to #170 (nwidart/laravel-modules v13 runtime compatibility on the
5.xline; composer constraints landed in #169 and #174)Test plan
vendor/bin/pest --ci(17 tests)./vendor/bin/phpstan analysevendor/bin/pint