Add ability to set timezone in PHP#148
Open
paalbra wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@coolacid Do you have any thoughts regarding this? :) |
Contributor
Author
|
I've fixed this in my own MISP, but I just realized that this PR actually was missing the part that sets timezone for cli. Added one new commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't seen this mentioned in any issues, but it is something I would like to see added myself.
It adds an ability to set time timezone directly in PHP.
If this is used you won't need to override the timezone in MISP itself. I.e. here:
https://github.com/MISP/MISP/blob/7283c8183ac5144f3cbc6f415dd6b1329a4435fa/app/Config/core.default.php#L243-L247
I've tried to follow the same coding style like I've seen in other scripts. Happy to hear any comments/thoughts.