Skip to content

Return guide get payload after study guide wait - #9

Merged
yupeng-dev merged 1 commit into
mainfrom
feat/guide-wait-returns-guide
Jun 30, 2026
Merged

Return guide get payload after study guide wait#9
yupeng-dev merged 1 commit into
mainfrom
feat/guide-wait-returns-guide

Conversation

@yupeng-dev

Copy link
Copy Markdown
Contributor

Summary

  • Change study guide wait so a successful wait fetches /v1/studies/:id/discussion-guide and returns that guide-get payload.
  • Keeps polling/failure/timeout behavior intact; only the success payload changes.

PR scope

  • Source-only change; no spec or unit-test files are included.

Validation

  • npm ci
  • npm run build
  • npm run typecheck
  • env -u COOKIY_SERVER_URL npm test
  • git diff --check

Manual note

  • The env-unset test command avoids inheriting a local COOKIY_SERVER_URL override into the existing test suite.

Constraint: Agents expect study guide wait to have the same successful output contract as study guide get.\nRejected: Return activity sources.guide directly | that omits the guide-get fields now needed by downstream callers.\nConfidence: high\nScope-risk: narrow\nDirective: Keep wait polling behavior separate from the final payload fetch.\nTested: npm ci; npm run build; npm run typecheck; env -u COOKIY_SERVER_URL npm test; git diff --check.\nNot-tested: Live API run against dev/preview token.
@yupeng-dev
yupeng-dev merged commit 6714fca into main Jun 30, 2026
1 check passed
@yupeng-dev
yupeng-dev deleted the feat/guide-wait-returns-guide branch June 30, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant