feat(crjson): implement isUpdateManifest and isCompressedManifest fields#2185
Open
sherifhanna-google wants to merge 2 commits into
Open
feat(crjson): implement isUpdateManifest and isCompressedManifest fields#2185sherifhanna-google wants to merge 2 commits into
sherifhanna-google wants to merge 2 commits into
Conversation
Update the crJSON manifest exporter to align with the latest crJSON schema from specs-core. This adds two new required boolean fields to each manifest in the output JSON: - isUpdateManifest: true if it is a c2um update manifest - isCompressedManifest: true if the manifest was compressed in the store Updated the schema file fixture and adjusted the schema compliance test suite to enforce and validate these new required properties. TAG=agy CONV=5a6c8836-497c-425a-8729-a219cf82cbe6
andyparsons
requested review from
andyparsons,
gpeacock,
lrosenthol and
mauricefisher64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the crJSON manifest exporter to align with the latest crJSON schema
from specs-core. This adds two new required boolean fields to each manifest
in the output JSON:
Updated the schema file fixture and adjusted the schema compliance test suite
to enforce and validate these new required properties.
TAG=agy
CONV=5a6c8836-497c-425a-8729-a219cf82cbe6