Fix for CAI-10364#2168
Open
mpgopala wants to merge 1 commit into
Open
Conversation
1. Gate localhost→HTTP to #[cfg(test)] 2. Block IP literals in to_url() 3. Pass a resolver parameter get_did_doc so that above two fixes are applied for did:web processing
Merging this PR will not alter performance
Comparing 
Footnotes
|
ok-nick
reviewed
May 26, 2026
Comment on lines
+160
to
+161
| let _resolver = Context::new().resolver_async(); | ||
| self.check_issuer_signature_async(&sign1, &ica_credential, _resolver.as_ref()) |
Contributor
There was a problem hiding this comment.
This is where the problem becomes tricky. The resolver here isn't actually the one passed in by the user with restrictions and such. In the reader we call a higher-level function that eventually boils down to here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Give a narrative description of what has been changed.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.