feat: Upgrade crb4#2
Merged
Merged
Conversation
Completes full CRB v3→v4 migration across all implementation units:
U1: Upgrade dependencies
- @zengenti/contensis-react-base ^3→^4, styled-components ^5→^6
- @types/react ^17→^18, react-refresh, @pmmmwh/react-refresh-webpack-plugin
- Remove deprecated: @types/react-helmet, @types/redux-immutable,
@types/react-router-dom, @types/react-loadable, @types/styled-components
- Add skipLibCheck + resolutions to handle nested @types/react conflicts
- .nvmrc: 18→22
U2: React Hot Loader → React Fast Refresh
- Remove react-hot-loader/babel from babel.config.js
- Remove hot(module)(AppRoot) wrapper from App.tsx
- Add ReactRefreshWebpackPlugin to webpack.config.dev.js
U3: Remove React Router v5 exact prop from StaticRoutes
U4: Remove getIn from selectors.js (replaced with optional chaining)
U5: Update withEvents.ts — return {searchOptions} from onRouteLoaded
instead of yield call(setRouteFilters). Params now provided by framework.
U6: Replace react-helmet with @zengenti/contensis-react-base/util Helmet
U7: Cleanup
- Delete legacy loadable.ts (react-loadable wrapper, unused)
- Update webpack server target: node18→node22
- Remove setNotFound/SET_ROUTE_LOADING/CALL_HISTORY_METHOD etc from
core redux re-exports (removed in CRB v4)
- Drop enableES5 from immer (removed in Immer v9)
SC v6 compatibility: update ~18 styled component definitions to use
styled.div<Props> generic instead of inline type annotations in template
literals. Fix useRef<T>(null) for React 18 strict MutableRefObject types.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fbeavan-zengenti
approved these changes
Apr 29, 2026
Collaborator
fbeavan-zengenti
left a comment
fbeavan-zengenti
left a comment
There was a problem hiding this comment.
Looks good to me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: review changes in
src/app/components/relatedLinks/RelatedLinks.container.tsxit looks like claude has just removed the functionality, is this correct and not used?