Fix #693: Add uniform bottom margin to h1 headings - #694
Open
Chetan175 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Chetan175 <chetanahuja175@gmail.com>
Contributor
|
I believe, it would be helpful to check if there are any other places where this fix is needed, to make sure this bug doesn't appear again. Just my opinion 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe the change
Fixes #693
This PR resolves an issue where
#(h1) headings in Markdown files were lacking a bottom margin, causing the text directly underneath to stick too closely to the headingThe fix adds
mb-6to theh1definition in the global@layer baseofmain.css. This ensures that all auto-generated markdownh1tags get a uniform bottom margin, while safely allowing custom UI components (likeHeroHeaderandPageHeader) to override it with their own explicit utility classes.Before screenshot / screen recording
After screenshot / screen recording
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)