fix(a11y): make meeting-minutes modal keyboard-operable - #690
Open
Daksha1611 wants to merge 1 commit into
Open
Conversation
The dialog was toggled via the `open` attribute instead of showModal()/close(), so Escape didn't close it and the close icon was a non-focusable <div onClick>. Keyboard-only users had no way to close the modal once opened. - Drive the dialog with showModal()/close() so native Escape-to-close and focus-trapping work, and sync state back via the dialog's onClose event. - Replace the close-icon <div onClick> with a real <button> so it's reachable and operable via keyboard. Verified with a headless Chrome session driving real keyboard/focus events: Escape and Enter-on-close-button both close the modal, and the dialog now opens via showModal() (matches :modal). Fixes containers#686 Signed-off-by: Daksha1611 <mehtadaksha1611@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a keyboard accessibility issue in the meeting-minutes modal.
The dialog is now controlled using the native
showModal()andclose()APIs instead of toggling theopenattribute, restoring built-in modal behavior such as closing with Escape. The close icon was also replaced with a semantic<button>, making it focusable and operable with the keyboard.Verified that:
:modal).Fixes #686.