fix: make community meetings dropdown keyboard accessible - #688
Open
airajena wants to merge 1 commit into
Open
Conversation
Replace the clickable div used for the community meetings dropdown with a button so it can be focused and used with the keyboard. Add aria-expanded and aria-controls for screen reader support and handle Escape to close the dropdown. Verified with yarn typecheck and yarn build. Signed-off-by: airajena <airajena0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The community meetings dropdown (
src/components/utilities/DropDown) used a clickable<div>for its toggle, so it couldn't be reached or operated with the keyboard, and wasn't exposed as an interactive control to screen readers.<div>toggle with a<button>, matching the pattern already used in the siblingDropdownButtoncomponent.aria-expandedandaria-controlsso assistive tech can tell when the options panel is open.Testing
yarn typecheckandyarn buildboth pass.Fixes #687
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)