Skip to content

fix: make community meetings dropdown keyboard accessible - #688

Open
airajena wants to merge 1 commit into
containers:mainfrom
airajena:fix/dropdown-keyboard-accessibility
Open

fix: make community meetings dropdown keyboard accessible#688
airajena wants to merge 1 commit into
containers:mainfrom
airajena:fix/dropdown-keyboard-accessibility

Conversation

@airajena

Copy link
Copy Markdown

What this does

The community meetings dropdown (src/components/utilities/DropDown) used a clickable <div> for its toggle, so it couldn't be reached or operated with the keyboard, and wasn't exposed as an interactive control to screen readers.

  • Replaced the <div> toggle with a <button>, matching the pattern already used in the sibling DropdownButton component.
  • Added aria-expanded and aria-controls so assistive tech can tell when the options panel is open.
  • Added an Escape key handler to close the dropdown.

Testing

  • yarn typecheck and yarn build both pass.
  • Manually checked the community meetings dropdown still opens and closes correctly with both mouse and keyboard.

Fixes #687

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • [ x] Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • [ x] Referenced issues using Fixes: #00000 in commit message (if applicable)
  • [x ] PR description, commit message, and GitHub comments are human-written, per LLM Policy

Replace the clickable div used for the community meetings dropdown
with a button so it can be focused and used with the keyboard.

Add aria-expanded and aria-controls for screen reader support and
handle Escape to close the dropdown.

Verified with yarn typecheck and yarn build.

Signed-off-by: airajena <airajena0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Community meetings dropdown is not keyboard accessible

1 participant