fix: remove DOM dependency from ArticleCard - #684
Open
vaishnavi192 wants to merge 1 commit into
Open
Conversation
Fixes: containers#683 Signed-off-by: vaishnavi192 <vaishnavi.m1084@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #683
Removed the browser-dependent document.createElement() usage from ArticleCard and replaced the HTML-to-text conversion with an SSR-safe utility using the existing html-react-parser dependency. This allows ArticleCard to render during Docusaurus server-side/static rendering without requiring browser APIs.
####Before Screenshot

Terminal output showing the Docusaurus build failing while rendering /ssrissue because document is unavailable.
Test File

After Screenshot
Terminal output showing the Docusaurus build completing successfully after removing the browser DOM dependency from ArticleCard.

Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)