fix(ui): prevent Podman logo from clipping in mobile sidebar header - #682
Open
yashwaghmare123 wants to merge 1 commit into
Open
fix(ui): prevent Podman logo from clipping in mobile sidebar header#682yashwaghmare123 wants to merge 1 commit into
yashwaghmare123 wants to merge 1 commit into
Conversation
Signed-off-by: Yash Waghmare <157041623+yashwaghmare123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Podman logo gets cut off at the top when the mobile sidebar menu is open.
Why
The logo has a fixed height (6.25rem) that's sized for the desktop navbar,
which is stretched taller to fit it. The mobile sidebar header doesn't have
that same extra height, so the logo overflows and gets clipped.
Fix
Added a small override so the logo scales down just inside the mobile
sidebar, without touching how it looks on desktop:
```css
.navbar-sidebar__brand .navbar__logo {
height: 3rem;
}
```
Testing
Tested locally on mobile view with the sidebar open, checked desktop still
looks the same, and checked both light and dark mode.
Screenshots
Before:
After: