fix: correct typeof window check in NotFound component for SSR - #676
Open
Chetan175 wants to merge 1 commit into
Open
fix: correct typeof window check in NotFound component for SSR#676Chetan175 wants to merge 1 commit into
Chetan175 wants to merge 1 commit into
Conversation
The NotFound component incorrectly checked for the window object using `typeof window !== undefined`. Because `typeof` always returns a string, this check was always evaluating to true, comparing the string "undefined" to the primitive `undefined`. This commit updates the check to compare against the string `'undefined'`, preventing ReferenceErrors when the component is evaluated during Server Side Rendering (SSR) in Docusaurus. Signed-off-by: Chetan175 <chetanahuja175@gmail.com>
Contributor
|
There is no issue being referenced to this PR. In case if the issue hasn't been raised, I believe, you should raise issue for this and reference this PR to that issue. |
Author
Thanks for the heads up , i have opened the issue #679 and linked this PR to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe the change
Fixes #679
The NotFound component incorrectly checked for the window object using
typeof window !== undefined. Becausetypeofalways returns a string, this check was always evaluating to true, comparing the string "undefined" to the primitiveundefined.This commit updates the check to compare against the string
'undefined', preventing ReferenceErrors when the component is evaluated during Server Side Rendering (SSR) in Docusaurus.Before screenshot / screen recording
N/A - This is a backend/SSR logic fix, so there are no visual UI changes.
After screenshot / screen recording
N/A - This is a backend/SSR logic fix, so there are no visual UI changes.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
git commit -s). (If needed, usegit commit -s --amend). The author email must match the sign-off email address. See CONTRIBUTING.md for more information.Fixes: #00000in commit message (if applicable)