Skip to content

fix(security): prevent tabnabbing by adding rel noopener noreferrer t… #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sarthakkaushik927 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(security): prevent tabnabbing by adding rel noopener noreferrer t… #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/components/content/ThankYouSection/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,42 +33,49 @@ function ThankYouSection(): JSX.Element {
<a
href={redHat.href}
target="_blank"
rel="noopener noreferrer"
className="mx-4 mb-4 inline-block rounded-md p-4 dark:bg-gray-100 lg:row-span-2 lg:row-start-1 lg:mb-0">
<img {...redHat} className="mx-auto p-4" />
</a>
<a
href={amadeus.href}
target="_blank"
rel="noopener noreferrer"
className="mx-4 mb-4 inline-block rounded-md p-4 dark:bg-gray-100 lg:mb-0 lg:flex lg:h-28 lg:w-80 lg:items-center">
<img {...amadeus} className="object-fit mx-auto max-w-sm p-4 " />
</a>
<a
href={suse.href}
target="_blank"
rel="noopener noreferrer"
className="mx-4 mb-4 inline-block rounded-md p-4 dark:bg-gray-100 lg:mb-0 lg:flex lg:h-28 lg:w-80 lg:items-center">
<img {...suse} className="object-fit mx-auto max-w-sm p-4 " />
</a>
<a
href={motorola.href}
target="_blank"
rel="noopener noreferrer"
className="mx-4 mb-4 inline-block rounded-md p-4 dark:bg-gray-100 lg:row-span-2 lg:row-start-1 lg:mb-0">
<img {...motorola} className="mx-auto p-4" />
</a>
<a
href={ntt.href}
target="_blank"
rel="noopener noreferrer"
className="mx-4 mb-4 inline-block rounded-md p-4 dark:bg-gray-100 lg:mb-0 lg:flex lg:h-28 lg:w-80 lg:items-center">
<img {...ntt} className="object-fit mx-auto max-w-sm p-4 " />
</a>
<a
href={ibm.href}
target="_blank"
rel="noopener noreferrer"
className="col-span-3 mx-4 mb-4 inline-block rounded-md p-4 dark:bg-gray-100 lg:mb-0 lg:flex lg:h-28 lg:w-80 lg:items-center">
<img {...ibm} className="object-fit mx-auto max-w-sm p-4 " />
</a>
<a
href={debian.href}
target="_blank"
rel="noopener noreferrer"
className="mx-4 mb-4 inline-block rounded-md p-4 dark:bg-gray-100 lg:row-span-2 lg:row-start-1 lg:mb-0">
<img {...debian} className="mx-auto p-4" />
</a>
Expand Down
2 changes: 2 additions & 0 deletions src/components/ui/ArticleCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ function ArticleCard(props: ArticleCardProps) {
<a
href={props.path}
target="_blank"
rel="noopener noreferrer"
className="text-white no-underline hover:text-blue-100 hover:no-underline dark:text-white dark:hover:text-blue-50">
{sanitizeHtml(props.title)}
</a>
Expand Down Expand Up @@ -83,6 +84,7 @@ function ArticleCard(props: ArticleCardProps) {
<a
href={props.path}
target="_blank"
rel="noopener noreferrer"
className="text-white no-underline hover:text-blue-100 hover:no-underline dark:text-white dark:hover:text-blue-50">
{sanitizeHtml(props.title)}
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/Testimonial/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function Testimonial(props: TestimonialProps) {
</div>
<div className="mt-2 mb-4 truncate">
<p className="whitespace-normal text-gray-900 dark:text-gray-300 leading-snug mb-2">{props.description}</p>
{props.featuredlink && <a target="_blank" href={props.featuredlink}>{props.featuredlink}</a>}
{props.featuredlink && <a target="_blank" rel="noopener noreferrer" href={props.featuredlink}>{props.featuredlink}</a>}
</div>
<div className="mt-auto self-start text-gray-300 dark:text-gray-700 italic">
<a href={props.path} className="text-gray-300 dark:text-gray-700 dark:hover:text-gray-700 no-underline hover:no-underline hover:bg-purple-300">
Expand Down