fix: improve type safety in PlayOnScroll and CommunityMeetingsCardGrid - #660
Open
Chaitu7032 wants to merge 2 commits into
Open
fix: improve type safety in PlayOnScroll and CommunityMeetingsCardGrid#660Chaitu7032 wants to merge 2 commits into
Chaitu7032 wants to merge 2 commits into
Conversation
added 2 commits
August 9, 2026 10:02
Signed-off-by: Chaitu7032 <konakrishnachaitanya1@gmail.com>
Signed-off-by: Chaitu7032 <konakrishnachaitanya1@gmail.com>
Chaitu7032
force-pushed
the
fix/community-meetings-card-types
branch
from
August 9, 2026 04:35
a5486b4 to
a41de23
Compare
Chaitu7032
changed the title
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve two type-safety TypeScript problems preventing yarn typecheck from passing.
1] Add a PlayOnScroll type using VideoProps that already exists for proper prop recognition in features.tsx
2] Resolve type-safety problems in CommunityMeetingsCardGrid by appropriately narrowing parsed markdown nodes when accessing properties.
3] Maintain existing functionality and link extraction of meeting recordings.
fixes #661
Before screenshot / screen recording
Not applicable. This PR contains type-safety and build-quality fixes only; there are no intended UI changes.
After screenshot / screen recording
Not applicable. No visual or runtime behavior was intentionally changed.
Checklist
Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
PR description, commit message, and GitHub comments are human-written, per LLM Policy