perf: replace scroll listener with IntersectionObserver - #659
Open
airajena wants to merge 1 commit into
Open
Conversation
The PlayOnScroll component was checking getBoundingClientRect() on every scroll event to determine whether the video should play or pause. Since the component is mounted four times on /features, this meant four synchronous layout reads were happening on every scroll. Replaced the scroll listener with an IntersectionObserver using a threshold of 1, keeping the same fully-visible behavior while avoiding the repeated layout reads during scrolling. Verified with yarn typecheck and yarn build, and manually checked /features to make sure videos still play and pause correctly while scrolling. Fixes: containers#656 Signed-off-by: airajena <airajena0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe the change
The PlayOnScroll component was checking getBoundingClientRect() on every scroll event to determine whether the video should play or pause. Since the component is mounted four times on /features, this meant four synchronous layout reads were happening on every scroll.
Replaced the scroll listener with an IntersectionObserver using a threshold of 1, keeping the same fully-visible behavior while avoiding the repeated layout reads during scrolling.
Verified with yarn typecheck and yarn build, and manually checked /features to make sure videos still play and pause correctly while scrolling.
Fixes: #656
Before screenshot / screen recording
After screenshot / screen recording
Checklist
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)