fix(ui): replace outer p tag with div in CustomCard to prevent invalid HTML nesting - #654
Open
Vinit-786 wants to merge 1 commit into
Open
fix(ui): replace outer p tag with div in CustomCard to prevent invalid HTML nesting#654Vinit-786 wants to merge 1 commit into
Vinit-786 wants to merge 1 commit into
Conversation
…d HTML nesting Signed-off-by: Vinit-786 <vinitmahajan175@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #653
Concisely describe the change
Replaced the outer
<p id="cardBody-parsed">wrapper with a<div>insrc/components/ui/CustomCard/index.tsx.MarkdownrendersReactMarkdown, which outputs block-level elements such as<p>for markdown content. Wrapping it inside another<p>produces invalid nested paragraph markup. Using a<div>preserves valid HTML while allowing markdown content to render correctly.Before screenshot / screen recording
After screenshot / screen recording
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)