Update go to 1.26.5#13725
Conversation
Includes security fixes to the crypto/tls and os packages. Assisted-by: Antigravity Signed-off-by: Chris Henzie <chrishenzie@gmail.com>
There was a problem hiding this comment.
Pull request overview
Updates the repository’s pinned Go toolchain references to Go 1.26.5 (per PR description: includes security fixes), aligning developer environments, CI, and build/test images on the same patch release.
Changes:
- Bump Go version references from 1.26.4 → 1.26.5 across CI workflows and the reusable
install-goaction. - Update Go versions used by local/dev tooling (Vagrant, devcontainer, Windows env prep).
- Update Go version used in test/fuzz build images/scripts.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Vagrantfile | Bumps provisioned Go version to 1.26.5 for Vagrant-based dev envs. |
| script/setup/prepare_env_windows.ps1 | Updates Chocolatey Go package version to 1.26.5 on Windows setup. |
| contrib/fuzz/oss_fuzz_build.sh | Downloads/extracts Go 1.26.5 tarball for OSS-Fuzz builds. |
| contrib/Dockerfile.test | Updates test image Go version ARG to 1.26.5. |
| .github/workflows/release/Dockerfile | Updates release workflow Go base image version to 1.26.5. |
| .github/workflows/ci.yml | Updates CI matrix Go version to 1.26.5. |
| .github/workflows/api-release.yml | Updates API release workflow GO_VERSION to 1.26.5. |
| .github/actions/install-go/action.yml | Updates default Go version for the reusable install action to 1.26.5. |
| .devcontainer/devcontainer.json | Updates devcontainer Go feature version to 1.26.5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, windows-latest] | ||
| go-version: ["1.26.4"] # 1.25 is not supported due to k8s 1.36 requiring 1.26 | ||
| go-version: ["1.26.5"] # 1.25 is not supported due to k8s 1.36 requiring 1.26 | ||
| exclude: |
There was a problem hiding this comment.
go.mod defines the minimum version (in this case it was driven up through dependencies)
|
Image isn't quite ready yet it seems. |
|
Image PR was done in docker-library/official-images#21799, trying to find how the push happens somewhere in https://doi-janky.infosiftr.net/... |
|
Heh, yes, I'm also always forgetting where to look for the pipeline 😅 |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (assuming CI is happy once the images are up)
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
|
/retest |
|
/cherry-pick release/2.3 |
|
@chrishenzie: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
|
@chrishenzie: new pull request created: #13732 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Includes security fixes to the crypto/tls and os packages.
Assisted-by: Antigravity