feat: update blueprint types for array-only multi-module storage#1193
Merged
Conversation
- Remove has_storage from BlueprintEntityType (now derived from storage[].length > 0) - Change storage from BlueprintStorageConfig to BlueprintStorageConfig[] (array-only) - Add storage_key field to BlueprintStorageConfig for multi-module support - Update b2b-storage preset description to reference array format
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Start from main's generated file and apply only the storage-related changes to avoid picking up unmerged node type definitions (LimitWarning*, EventReferral, etc.) that don't have params generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates TypeScript blueprint types to match the multi-storage-module support added in constructive-db PR #1228.
Breaking changes:
has_storageremoved fromBlueprintEntityType— now derived fromstorage[].length > 0storagechanged fromBlueprintStorageConfigtoBlueprintStorageConfig[](array-only, no object form)storage_keyfield added toBlueprintStorageConfigfor multi-module discriminationCompanion to: https://github.com/constructive-io/constructive-db/pull/1228
Review & Testing Checklist for Human
BlueprintStorageConfighasstorage_key?: stringwith correct JSDocBlueprintEntityType.storageisBlueprintStorageConfig[](array, not single object)has_storageis no longer onBlueprintEntityTypestoragearray (nothas_storage=true)Notes
LimitWarningCounterParams/LimitWarningAggregateParams/LimitWarningRateParamsbuild errors in the generated file are pre-existing on main (node types merged but params not yet generated by the static fallback). Not introduced by this PR.Link to Devin session: https://app.devin.ai/sessions/c0494871633d4beb91f1e16e53c776d1
Requested by: @pyramation