Skip to content

新增单元测试,并编写基础控制器部分的单元测试样例。#24

Open
bullub wants to merge 1 commit into
conseweb:poefrom
bullub:add-unit-test
Open

新增单元测试,并编写基础控制器部分的单元测试样例。#24
bullub wants to merge 1 commit into
conseweb:poefrom
bullub:add-unit-test

Conversation

@bullub

@bullub bullub commented Dec 18, 2016

Copy link
Copy Markdown
Contributor

#23
运行单元测试
npm install
npm install karma -g

@ckeyer ckeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread karma.conf.js
"use strict";
module.exports = function (config) {
config.set({
browsers: ['Chrome'],

@ckeyer ckeyer Dec 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里使用Chrome的话,会增加外部chrome的依赖,在服务器上是没法执行的,前期,咱们暂时尽量少的引入外部依赖,是否可以考虑PhantomJS或其它?

@ckeyer

ckeyer commented Dec 19, 2016

Copy link
Copy Markdown
Contributor

@bullub 这个pr先优先级靠后,先完成我有Assignees你的吧,这个先放这儿吧

@ckeyer ckeyer changed the title #23 新增单元测试,并编写基础控制器部分的单元测试样例。 新增单元测试,并编写基础控制器部分的单元测试样例。 Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants