docs(#1782): fix make ci description in AGENTS.md#1783
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#1782): fix make ci description in AGENTS.md#1783fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Update the make ci comment to match the actual Makefile ci target prerequisites. Three inaccuracies corrected: (1) test -> quiet-test, (2) added missing regal-test, (3) reordered to match actual Makefile target order. Closes #1782
|
🤖 Finished Review · ✅ Success · Started 1:43 PM UTC · Completed 1:52 PM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ReviewFindingsMedium
Labels: PR is a documentation-only change fixing AGENTS.md to match actual Makefile targets |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| make fmt # Format rego (run before every commit) | ||
| make lint # Regal linter + license headers | ||
| make ci # Full CI: test + acceptance + fmt-check + lint + opa-check + conventions-check + generate-docs | ||
| make ci # Full CI: quiet-test + acceptance + opa-check + conventions-check + fmt-check + lint + regal-test + generate-docs |
There was a problem hiding this comment.
[medium] protected-path
This PR modifies AGENTS.md, which is a protected governance/infrastructure file. The PR links to issue #1782 and explains the rationale (correcting inaccurate make ci description). The fix is verified accurate against the Makefile ci target. Human approval is always required for protected-path changes, regardless of context.
fullsend-ai-review
Bot
added
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make cidescription in AGENTS.md to match the actual Makefilecitarget prerequisitestest→quiet-test, added missingregal-test, reordered to match actual Makefile target orderTesting
grep '^ci:' Makefileoutput in both content and orderingCloses #1782
Post-script verification
agent/1782-fix-ci-docs)a0ef39146075ba0e32fc6a40e4aab586c14d447d..HEAD)