Skip to content

chore: update fullsend shim workflow #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-fullsend wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −14
Open

chore: update fullsend shim workflow #1767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .github/workflows/fullsend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,3 @@
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# SPDX-License-Identifier: Apache-2.0

# lint-workflow-size: max-lines=280

@fullsend-ai-review fullsend-ai-review Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] style/conventions

Removing the Apache 2.0 license header breaks the addlicense -check step in make lint. All other workflow files retain the standard header. CI (all-tests-and-checks) is already failing on this commit.

Suggested fix: Re-add the license header with the # Copyright The Conforma Contributors preamble used by peer workflow files, or add -ignore .github/workflows/fullsend.yaml to LICENSE_IGNORE in the Makefile if the file should be exempt from the check.

@fullsend-ai-review fullsend-ai-review Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[critical] CI breakage

Removing the Apache 2.0 license header will cause make lint to fail in CI. The Makefile lint target runs google/addlicense -check on all files (only .git/** and .idea/** are excluded). After this PR, fullsend.yaml has no license header, so addlicense will flag it as missing. The pre-merge-ci.yaml workflow runs make ci (which includes make lint) on every PR to main.

Suggested fix: Either keep the license header (adding the missing # Copyright The Conforma Contributors line to match other workflow files) or add -ignore .github/workflows/fullsend.yaml to LICENSE_IGNORE in the Makefile.

# fullsend shim workflow (workflow_call mode)
# Routes events to agent workflows in .fullsend via workflow_call.
Expand Down
Loading