-
Notifications
You must be signed in to change notification settings - Fork 54
Update github actions (release-v0.8) (minor) #1732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v0.8
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Label PR by size | ||
| uses: conforma/pr-size-label-action@v1.0.0 | ||
| uses: conforma/pr-size-label-action@v1.2.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] pattern-inconsistency Every other third-party action in this repository uses SHA pinning with version comments (@ # ), but conforma/pr-size-label-action uses a mutable tag reference (@v1.2.0). This is a pre-existing inconsistency that this PR perpetuates. Suggested fix: Align with the repository convention: uses: conforma/pr-size-label-action@<full-sha-of-v1.2.0> # v1.2.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] supply-chain pinning The conforma/pr-size-label-action is referenced by mutable tag (v1.2.0) instead of a SHA pin. This action runs on pull_request_target with pull-requests:write and issues:write permissions, meaning a compromised or force-pushed tag could execute arbitrary code with write access to the repository. The pull_request_target trigger combined with write permissions makes this an elevated-risk combination. Suggested fix: Pin conforma/pr-size-label-action to the full commit SHA for v1.2.0. Consider also pinning other mutable-referenced actions for consistency. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] supply-chain conforma/pr-size-label-action uses a mutable version tag (v1.2.0) instead of a SHA pin, inconsistent with the pinning strategy used for all other actions in these workflows. Pre-existing issue, not introduced by this PR. Suggested fix: Pin to the full commit SHA for v1.2.0 with a version comment, matching the pattern used by other actions (e.g., actions/setup-go@924ae3a1... # v6.5.0). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] pin-integrity The action conforma/pr-size-label-action@v1.2.0 is pinned to a mutable version tag rather than a full commit SHA. Every other action across all six workflow files uses SHA pinning with a version comment. A mutable tag can be force-pushed, silently replacing the action code. This workflow runs on pull_request_target with pull-requests: write and issues: write permissions, so a compromised action would execute with elevated write permissions. The risk is partially mitigated by the action being owned by the same conforma organization. Suggested fix: Pin to a full 40-character commit SHA with a version comment: uses: conforma/pr-size-label-action@ # v1.2.0. Determine the SHA by checking the v1.2.0 tag on GitHub. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] supply-chain conforma/pr-size-label-action uses a mutable tag reference (@v1.2.0) instead of a SHA pin, unlike all other actions in the repository. Tag references can be repointed, posing a supply-chain integrity risk. This is a pre-existing pattern not introduced by this PR. Suggested fix: Pin to the commit SHA for v1.2.0 with a version comment (e.g., conforma/pr-size-label-action@ # v1.2.0), matching the convention used by all other actions in this repository. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium] supply-chain
conforma/pr-size-label-action is referenced by a mutable tag (v1.2.0) rather than a pinned commit SHA. This workflow runs on pull_request_target with pull-requests: write and issues: write permissions, making tag mutability a meaningful supply-chain risk.
Suggested fix: Pin to a specific commit SHA corresponding to v1.2.0, following the established pattern: uses: conforma/pr-size-label-action@ # v1.2.0