-
Notifications
You must be signed in to change notification settings - Fork 54
Update github actions (main) (minor) #1678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Label PR by size | ||
| uses: conforma/pr-size-label-action@v1.0.0 | ||
| uses: conforma/pr-size-label-action@v1.2.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] supply-chain integrity conforma/pr-size-label-action is pinned to a mutable tag (v1.2.0) rather than a full commit SHA. This action runs on pull_request_target with write permissions to pull-requests and issues. The tag was updated in this PR without switching to SHA pinning, unlike all other action updates in this diff which use SHA pinning. Suggested fix: Pin conforma/pr-size-label-action to a full commit SHA with a version comment, consistent with the pinning practice used for all other actions in this repository. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] Supply Chain / Action Pinning The conforma/pr-size-label-action is pinned to a mutable tag (v1.2.0) rather than to an immutable SHA hash. All other third-party actions in this repository use SHA pinning with version comments. A mutable tag can be force-pushed to point at a malicious commit, which is particularly concerning here because this workflow uses the pull_request_target trigger with pull-requests: write and issues: write permissions. Suggested fix: Pin conforma/pr-size-label-action to its full commit SHA corresponding to v1.2.0, with a version comment. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] Supply Chain / Action Pinning conforma/pr-size-label-action is referenced by mutable tag (v1.2.0) instead of a pinned commit SHA. This action runs on pull_request_target with pull-requests:write and issues:write permissions. A mutable tag can be force-pushed to point at arbitrary code, allowing a supply-chain compromise to obtain write access to PRs and issues. All other third-party actions in this repository are properly SHA-pinned. Suggested fix: Pin conforma/pr-size-label-action to the full commit SHA corresponding to v1.2.0, e.g.: uses: conforma/pr-size-label-action@ # v1.2.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] supply-chain conforma/pr-size-label-action is pinned by mutable tag (@v1.2.0) rather than by immutable commit SHA. This is a pre-existing pattern (was @v1.0.0), not introduced by this PR, but perpetuated here. This action runs under a pull_request_target trigger with pull-requests: write and issues: write permissions, making tag-only pinning a supply-chain risk. Suggested fix: Pin to the full commit SHA corresponding to v1.2.0, e.g.: uses: conforma/pr-size-label-action@ # v1.2.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] supply-chain
Suggested fix: Pin to a full commit SHA: uses: conforma/pr-size-label-action@ # v1.2.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] security conforma/pr-size-label-action is pinned by mutable tag (@v1.2.0) rather than commit hash. This action runs in a pull_request_target workflow with write permissions (pull-requests: write, issues: write). Tag-based pinning is less resilient to supply-chain attacks. This is a pre-existing pattern (was @v1.0.0), not introduced by this PR. Suggested fix: Pin the action by commit hash with a version comment, e.g., uses: conforma/pr-size-label-action@ # v1.2.0 |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium] supply-chain
The action conforma/pr-size-label-action@v1.2.0 is pinned to a mutable version tag instead of an immutable SHA commit hash. Every other action in this repository uses SHA pinning. This is a pre-existing inconsistency perpetuated by this PR. The risk is elevated because this workflow uses the pull_request_target trigger with pull-requests: write and issues: write permissions.
Suggested fix: Pin to the full commit SHA of the v1.2.0 release with a version comment, e.g., uses: conforma/pr-size-label-action@ # v1.2.0