Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,17 @@ jobs:

steps:
- name: Harden Runner
uses: step-security/harden-runner@a90bcbc6539c36a85cdfeb73f7e2f433735f215b # v2.15.0
uses: step-security/harden-runner@bf7454d06d71f1098171f2acdf0cd4708d7b5920 # v2.20.0
with:
egress-policy: audit
disable-telemetry: true

- name: Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@89a39a4e59826350b863aa6b6252a07ad50cf83e # v4.32.4
uses: github/codeql-action/init@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4.37.3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -78,7 +78,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@89a39a4e59826350b863aa6b6252a07ad50cf83e # v4.32.4
uses: github/codeql-action/autobuild@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4.37.3

# ℹ️ Command-line programs to run using the OS shell.
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
Expand All @@ -91,6 +91,6 @@ jobs:
# ./location_of_script_within_repo/buildscript.sh

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@89a39a4e59826350b863aa6b6252a07ad50cf83e # v4.32.4
uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4.37.3
with:
category: "/language:${{matrix.language}}"
2 changes: 1 addition & 1 deletion .github/workflows/label-pr-size.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Label PR by size
uses: conforma/pr-size-label-action@v1.0.0
uses: conforma/pr-size-label-action@v1.2.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] supply-chain

The action conforma/pr-size-label-action@v1.2.0 is pinned to a mutable version tag instead of an immutable SHA commit hash. Every other action in this repository uses SHA pinning. This is a pre-existing inconsistency perpetuated by this PR. The risk is elevated because this workflow uses the pull_request_target trigger with pull-requests: write and issues: write permissions.

Suggested fix: Pin to the full commit SHA of the v1.2.0 release with a version comment, e.g., uses: conforma/pr-size-label-action@ # v1.2.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] supply-chain integrity

conforma/pr-size-label-action is pinned to a mutable tag (v1.2.0) rather than a full commit SHA. This action runs on pull_request_target with write permissions to pull-requests and issues. The tag was updated in this PR without switching to SHA pinning, unlike all other action updates in this diff which use SHA pinning.

Suggested fix: Pin conforma/pr-size-label-action to a full commit SHA with a version comment, consistent with the pinning practice used for all other actions in this repository.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] Supply Chain / Action Pinning

The conforma/pr-size-label-action is pinned to a mutable tag (v1.2.0) rather than to an immutable SHA hash. All other third-party actions in this repository use SHA pinning with version comments. A mutable tag can be force-pushed to point at a malicious commit, which is particularly concerning here because this workflow uses the pull_request_target trigger with pull-requests: write and issues: write permissions.

Suggested fix: Pin conforma/pr-size-label-action to its full commit SHA corresponding to v1.2.0, with a version comment.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] Supply Chain / Action Pinning

conforma/pr-size-label-action is referenced by mutable tag (v1.2.0) instead of a pinned commit SHA. This action runs on pull_request_target with pull-requests:write and issues:write permissions. A mutable tag can be force-pushed to point at arbitrary code, allowing a supply-chain compromise to obtain write access to PRs and issues. All other third-party actions in this repository are properly SHA-pinned.

Suggested fix: Pin conforma/pr-size-label-action to the full commit SHA corresponding to v1.2.0, e.g.: uses: conforma/pr-size-label-action@ # v1.2.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] supply-chain

conforma/pr-size-label-action is pinned by mutable tag (@v1.2.0) rather than by immutable commit SHA. This is a pre-existing pattern (was @v1.0.0), not introduced by this PR, but perpetuated here. This action runs under a pull_request_target trigger with pull-requests: write and issues: write permissions, making tag-only pinning a supply-chain risk.

Suggested fix: Pin to the full commit SHA corresponding to v1.2.0, e.g.: uses: conforma/pr-size-label-action@ # v1.2.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] supply-chain

conforma/pr-size-label-action@v1.2.0 uses a mutable tag reference instead of a SHA-pinned commit hash. All other actions in this repository use SHA pinning. While pre-existing (was @v1.0.0), this update is a good opportunity to align with the repo supply chain hardening practices by pinning to a specific commit SHA.

Suggested fix: Pin to a full commit SHA: uses: conforma/pr-size-label-action@ # v1.2.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] security

conforma/pr-size-label-action is pinned by mutable tag (@v1.2.0) rather than commit hash. This action runs in a pull_request_target workflow with write permissions (pull-requests: write, issues: write). Tag-based pinning is less resilient to supply-chain attacks. This is a pre-existing pattern (was @v1.0.0), not introduced by this PR.

Suggested fix: Pin the action by commit hash with a version comment, e.g., uses: conforma/pr-size-label-action@ # v1.2.0

6 changes: 3 additions & 3 deletions .github/workflows/pre-merge-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,16 @@ jobs:
id-token: write
steps:
- name: Harden Runner
uses: step-security/harden-runner@a90bcbc6539c36a85cdfeb73f7e2f433735f215b # v2.15.0
uses: step-security/harden-runner@bf7454d06d71f1098171f2acdf0cd4708d7b5920 # v2.20.0
with:
egress-policy: audit
disable-telemetry: true

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0

- name: Setup Go environment
uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0
uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
with:
go-version-file: go.mod
cache: true
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/push-bundles.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,20 @@ jobs:

steps:
- name: Harden Runner
uses: step-security/harden-runner@a90bcbc6539c36a85cdfeb73f7e2f433735f215b # v2.15.0
uses: step-security/harden-runner@bf7454d06d71f1098171f2acdf0cd4708d7b5920 # v2.20.0
with:
egress-policy: audit
disable-telemetry: true

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
with:
# So we can see in which commit a bundle's content was
# most recently updated
fetch-depth: 0

- name: Setup Go environment
uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0
uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
with:
go-version-file: go.mod
cache: true
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ jobs:
steps:

- name: Harden Runner
uses: step-security/harden-runner@a90bcbc6539c36a85cdfeb73f7e2f433735f215b # v2.15.0
uses: step-security/harden-runner@bf7454d06d71f1098171f2acdf0cd4708d7b5920 # v2.20.0
with:
egress-policy: audit
disable-telemetry: true

- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
with:
fetch-depth: 0

Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
steps:

- name: Harden Runner
uses: step-security/harden-runner@a90bcbc6539c36a85cdfeb73f7e2f433735f215b # v2.15.0
uses: step-security/harden-runner@bf7454d06d71f1098171f2acdf0cd4708d7b5920 # v2.20.0
with:
egress-policy: audit
disable-telemetry: true
Expand Down Expand Up @@ -140,13 +140,13 @@ jobs:
steps:

- name: Harden Runner
uses: step-security/harden-runner@a90bcbc6539c36a85cdfeb73f7e2f433735f215b # v2.15.0
uses: step-security/harden-runner@bf7454d06d71f1098171f2acdf0cd4708d7b5920 # v2.20.0
with:
egress-policy: audit
disable-telemetry: true

- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
with:
fetch-depth: 0

Expand All @@ -161,7 +161,7 @@ jobs:
git push -f --tags

- name: Create a release
uses: softprops/action-gh-release@a06a81a03ee405af7f2048a818ed3f03bbf83c7b # v2.5.0
uses: softprops/action-gh-release@3bb12739c298aeb8a4eeaf626c5b8d85266b0e65 # v2.6.2
with:
name: ${{ needs.get_info.outputs.next_version }}
tag_name: ${{ needs.get_info.outputs.next_version }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/scorecards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ jobs:

steps:
- name: Harden Runner
uses: step-security/harden-runner@a90bcbc6539c36a85cdfeb73f7e2f433735f215b # v2.15.0
uses: step-security/harden-runner@bf7454d06d71f1098171f2acdf0cd4708d7b5920 # v2.20.0
with:
egress-policy: audit
disable-telemetry: true

- name: "Checkout code"
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
with:
persist-credentials: false

Expand Down Expand Up @@ -89,6 +89,6 @@ jobs:

# Upload the results to GitHub's code scanning dashboard.
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@89a39a4e59826350b863aa6b6252a07ad50cf83e # v4.32.4
uses: github/codeql-action/upload-sarif@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4.37.3
with:
sarif_file: results.sarif
Loading