-
Notifications
You must be signed in to change notification settings - Fork 54
Update go modules (release-v0.7) (minor) #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v0.7
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,8 +3,8 @@ module github.com/conforma/policy/acceptance | |
| go 1.23.6 | ||
|
|
||
| require ( | ||
| github.com/conforma/cli v0.7.95 | ||
| github.com/cucumber/godog v0.13.0 | ||
| github.com/conforma/cli v0.9.74 | ||
| github.com/cucumber/godog v0.15.1 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] breaking-version-risk cucumber/godog jumps from v0.13.0 to v0.15.1 (two 0.x minor versions). The acceptance tests use godog ScenarioContext, TestSuite, Options, and DocString types — signature or behavior changes could cause compilation failures. |
||
| ) | ||
|
|
||
| require ( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,13 +2,13 @@ module github.com/conforma/policy/docs | |
|
|
||
| go 1.24.2 | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] process yaml.v2 to yaml.v3 transition in docs/go.mod is a module path change driven by OPA v0.70.0. Safe since yaml.v3 is only an indirect dependency and docs/go.sum was properly updated. |
||
| require github.com/open-policy-agent/opa v0.68.0 | ||
| require github.com/open-policy-agent/opa v0.70.0 | ||
|
|
||
| require ( | ||
| github.com/OneOfOne/xxhash v1.2.8 // indirect | ||
| github.com/rcrowley/go-metrics v0.0.0-20200313005456-10cdbea86bc0 // indirect | ||
| github.com/xeipuuv/gojsonpointer v0.0.0-20190905194746-02993c407bfb // indirect | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] major-module-path-change Indirect dependency changes from gopkg.in/yaml.v2 to gopkg.in/yaml.v3, which is a different Go module path (major version change). Likely safe as an indirect dep driven by OPA v0.70.0 requirements, but should be verified that no other indirect dependency still requires yaml.v2. |
||
| github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| sigs.k8s.io/yaml v1.4.0 // indirect | ||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,12 +3,12 @@ module github.com/conforma/policy | |
| go 1.24.2 | ||
|
|
||
| require ( | ||
| github.com/conforma/cli v0.7.109 | ||
| github.com/google/addlicense v1.1.1 | ||
| github.com/open-policy-agent/conftest v0.55.0 | ||
| github.com/styrainc/regal v0.29.2 | ||
| github.com/tektoncd/cli v0.39.1 | ||
| oras.land/oras v1.2.3 | ||
| github.com/conforma/cli v0.9.74 | ||
| github.com/google/addlicense v1.2.0 | ||
| github.com/open-policy-agent/conftest v0.68.2 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [high] correctness The PR requires github.com/styrainc/regal v0.41.1, but regal v0.41.1 declares its module path as github.com/open-policy-agent/regal (transferred around v0.36). Go enforces strict module path matching. This is a hard build failure: go mod tidy, go build, and go test will all fail for the root module. Suggested fix: Change the require directive to github.com/open-policy-agent/regal v0.41.1. Update all import paths in Go source files. Then run go mod tidy. |
||
| github.com/styrainc/regal v0.42.0 | ||
| github.com/tektoncd/cli v0.45.0 | ||
| oras.land/oras v1.3.3 | ||
| ) | ||
|
|
||
| require ( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] correctness
conforma/cli v0.9.66 requires go >= 1.26.3, but the acceptance module on release-v0.7 declares go 1.23.6. Go will refuse to build. Additionally, transitive dependency module path conflicts compound the problem.
Suggested fix: Bump the go directive in acceptance/go.mod to at least 1.26.3, or pin conforma/cli to a version compatible with the declared Go version.