This repository was archived by the owner on Feb 1, 2026. It is now read-only.
tests/e2e: allow to superseed images in operator.sh#341
Open
wainersm wants to merge 2 commits into
Open
Conversation
`./tests/e2e/operator.sh install` is still tightly coupled with the build phase, which happen to push images to a local registry, so the install tries to always start the registry service. Now suppose that you want to run `./tests/e2e/operator.sh install` stand-alone to install images from quay.io, then the registry service locally is not needed. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
By exporting $KATA_PAYLOAD_IMG variable the `./tests/e2e/operator.sh install` will replace the default kata-payload image. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Member
|
lgtm |
ldoktor
reviewed
Jan 29, 2024
| "install": install only, | ||
| "wait_for_stabilization": wait for CoCo pods to be stable | ||
| "uninstall": uninstall the operator. | ||
| environment variables : |
Contributor
There was a problem hiding this comment.
I really like this section, could you please (in a separate commit) add the RUNTIMECLASS, which is already supported to be set?
ldoktor
reviewed
Jan 29, 2024
ldoktor
left a comment
Contributor
There was a problem hiding this comment.
Overall it looks good, only the already-supported-to-be-set variable is missing in the usage message. Could you please add it (Ideally as a first commit to introduce this section, alternatively just as a part of the current first commit which defines the section)
Contributor
|
lgtm |
beraldoleal
approved these changes
Jan 30, 2024
beraldoleal
left a comment
Member
There was a problem hiding this comment.
Except from the @ldoktor comments, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started working on adapting the Kata CI scripts to install from this operator. I will be trying to re-use the scripts in
tests/e2e/as much as possible, for example,tests/e2e/operator.sh installto install and check Kata Containers in the cluster's nodes. So far I faced two problems withoperator.shthough:operator.shuses the built-and-pushed-to-local-registry images so it always tries to start a local registry service. If it is installing from quay.io (or ghcr.io), for example, it makes no sense the local registry.So this PR address those two problems. Also by making
operator.shmore flexible, this will likely to solve issues when we start improving the operator CI pipeline as suggested in #309If that helps on review, here goes a sample of the code I'm writing for the Kata CI side:
I tested locally by running: