Skip to content

Backports for LLVM 7.1 [alt]#384

Open
carterbox wants to merge 2 commits into
conda-forge:7.xfrom
carterbox:llvm7.1-alt
Open

Backports for LLVM 7.1 [alt]#384
carterbox wants to merge 2 commits into
conda-forge:7.xfrom
carterbox:llvm7.1-alt

Conversation

@carterbox

@carterbox carterbox commented Jun 25, 2026

Copy link
Copy Markdown
Member

In this PR, I update the 7.x branch to LLVM 7.1 including backporting the new outputs from the main branch such as libllvm7.1, llvm-tools, llvmdev, lit, etc.

I modeled this the recipe on the main branch since that is what @h-vetinari requested.

The sonamed output is libllvm7.1 instead of libllvm7 because the shared library produced the build is libLLVM-7.1.so not libLLVM-7.so.

If this PR is rejected, we will be revending llvm 7.1 in numba-cuda-mlir.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@carterbox carterbox changed the base branch from main to 7.x June 25, 2026 23:13
@conda-forge-admin

conda-forge-admin commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/28249232299. Examine the logs at this URL for more detail.

@carterbox

Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/28219344078. Examine the logs at this URL for more detail.

Comment thread recipe/meta.yaml
Comment on lines +18 to +28
- patches/llvm-lto-static.patch # [win]
- patches/partial-testing.patch
- patches/0001-pass-through-QEMU_LD_PREFIX-SDKROOT.patch
- patches/twine_cfg_undefined_behavior.patch
- patches/D47188-svml-VF.patch
# Revert an upstream change for Numba
# ref: https://github.com/numba/llvmlite/blob/v0.29.0/conda-recipes/0001-Revert-Limit-size-of-non-GlobalValue-name.patch
- patches/0001-Revert-Limit-size-of-non-GlobalValue-name.patch
# Fix getTypeName() for GCC 14+: move __PRETTY_FUNCTION__ outside namespace llvm
# so template args use fully-qualified names (e.g. llvm::Module not Module)
- patches/fix-typename-gcc14.patch

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mix of old patches from the 7.x branch, one current patch from main, and a new patch to make the tests pass with the current GCC.

Comment thread recipe/meta.yaml
number: {{ build_number }}
skip: true # [win and vc<14]
number: 0
skip: true # [osx or ppc64le]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only care about Windows and Linux on ARM and x86; if someone wants a backport for other platforms they can ask.

Comment thread recipe/meta.yaml
- python 3.7
- cmake {{ cmake }}
- ninja
- python >=3,<3.13

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These old tests are not compatible with python 3.13 because pipe was removed from the standard library.

Comment thread recipe/meta.yaml
Comment on lines +42 to +45
- m2-coreutils # [win]
- m2-findutils # [win]
- m2-grep # [win]
- m2-sed # [win]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests require linux utils on Windows.

Comment thread recipe/bld.bat
-DLLVM_INSTALL_UTILS=ON ^
-DLLVM_USE_SYMLINKS=OFF ^
-DLLVM_UTILS_INSTALL_DIR=libexec\llvm ^
-DLLVM_BUILD_LLVM_C_DYLIB=OFF ^

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM_C is not available for Windows in this version.

@carterbox carterbox marked this pull request as ready for review June 26, 2026 06:11
Comment thread recipe/meta.yaml Outdated
…2026.06.25.08.09.32

Other tools:
- conda-build 26.3.0
- rattler-build 0.64.1
- rattler-build-conda-compat 1.4.15
@carterbox carterbox mentioned this pull request Jun 26, 2026
5 tasks

@h-vetinari h-vetinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There would be ways to clean this up further, but since this branch is so old, I don't consider that worth the time and effort on everyone's part. So LGTM. Thanks for trying to do this the "right" way, i.e. to avoid vendoring it. :)

I'll leave this open for a few days in case someone else from @conda-forge/llvmdev wants to opine.

@carterbox

Copy link
Copy Markdown
Member Author

@jakirkham, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants