Pin vllm, preflight prompt lengths, enrich engine-init errors in capture#2
Merged
Merged
Conversation
…ted probe import Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Pin vllm==0.19.0 in VLLMEngine.runtime_spec(): residual capture rides the extract_hidden_states speculative path, which changes shape across minor releases (0.19.1 regressed the v1 input validator). Unpinned installs let any image rebuild silently change engine behavior. - Tokenize all prompts before LLM() init and fail fast with the offending example keys when any exceed max_model_len, instead of erroring per-request minutes later after a full GPU cold start. - Wrap engine init so vLLM's opaque "Engine core initialization failed" carries the engine config and a KV-cache-fit hint into run catalogs (the root cause only prints to worker stdout otherwise). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Auditing the behavior-audit Pearl scoring failures traced every "Engine core initialization failed" / over-length failure to three gaps in the capture stack:
extract_hidden_statesspeculative path, which changes shape across minor releases (0.19.1 regressed the v1 input validator — same reason yora pins). Any image rebuild could silently change engine behavior.max_model_lensurfaced as a per-request error minutes after a full GPU cold start + 131 GB weight load, without naming the offending example.What
vllm==0.19.0inVLLMEngine.runtime_spec()with rationale comment (keep in sync withyora/modal_base.py; bump deliberately)._preflight_prompt_lengths(): tokenize all prompts beforeLLM()init; raiseSpecValidationErrorlisting offending example keys/counts._engine_init_error_message(): engine-init RuntimeErrors now carry the engine config (max_model_len, TP, gpu_memory_utilization, chunked prefill, …) and a KV-cache-fit hint into run catalogs.Validated end-to-end: the Pearl 1,000-session scoring run (6,355 examples, 40k context, H200:2) completed first-try in ~20 min through this code path.
🤖 Generated with Claude Code