Document TTY-detection limitation for goaccess, tqdm, etc.#427
Draft
asmacdo wants to merge 4 commits into
Draft
Conversation
duct starts the wrapped command with start_new_session=True and pipes stdout/stderr instead of a PTY, so isatty() in the child is false. Programs that adapt their output to that signal (goaccess refusing to read piped stdin, tqdm switching to its rate-limited non-TTY path) appear broken under duct. Add a FAQ entry that names the limitation, gives concrete workarounds for both tools, and shows the setsid recipe so users can reproduce and develop against the non-interactive path without duct. Refs: con#261, con#426 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage 91.74% 91.74%
=======================================
Files 15 15
Lines 1127 1127
Branches 140 140
=======================================
Hits 1034 1034
Misses 70 70
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a README FAQ entry explaining that duct’s default execution mode can change TTY detection for wrapped commands, which can cause behavior differences in tools like goaccess and tqdm.
Changes:
- Add a new FAQ section describing the “non-interactive / not-a-TTY” behavior when commands are run under duct.
- Provide concrete workarounds for goaccess and tqdm behavior differences.
- Provide a
setsidcommand recipe to reproduce similar non-TTY conditions outside of duct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
duct starts the wrapped command with start_new_session=True and pipes stdout/stderr instead of a PTY, so isatty() in the child is false. Programs that adapt their output to that signal (goaccess refusing to read piped stdin, tqdm switching to its rate-limited non-TTY path) appear broken under duct.
Add a FAQ entry that names the limitation, gives concrete workarounds for both tools, and shows the setsid recipe so users can reproduce and develop against the non-interactive path without duct.
Refs: #261, #426