Adds new photometer class for X-Rite i1Pro colorimeter#44
Open
guillermoaguilar wants to merge 4 commits into
Open
Adds new photometer class for X-Rite i1Pro colorimeter#44guillermoaguilar wants to merge 4 commits into
guillermoaguilar wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colorimeter returns XYZ tristimulus values. This class has a
readLuminancemethod that returns the Y component and areadTristimulusmethod that returns the three values. This last method should be used for color calibration (#38)The Colorimeter requires a calibration with a reference white patch that lies in its case; the device should be manually put there in its "bed" for calibration. The class forces a calibration every time the device is instantiated. When asking for a new measurement, it internally checks if calibration is required.
I tested it for our usual luminance calibration pipeline, and it works without issues. Typical calibration in the lab is done with n=256 intensity values and 3 repetitions. With these settings, the colorimeter does not require a calibration midway through measurements. And it is actually a bit faster than the Minolta.
This PR may need editing if we merge PR #32 first. In this PR, the instantiation of the Colorimeter (still) occurs in
hrl/hrl.pyWhen merged it closes #37