Feedback#1
Open
github-classroom[bot] wants to merge 17 commits into
Open
Conversation
Todos os testes de aceitação para o frontend do compilador (análise léxica e sintática) foram aprovados nesta versão. As especificações léxicas (`lexer.jflex`) e sintáticas (`parser.cup`)
…Manager - Remove funções duplicadas de cálculo de localização do parser code - Substitui chamadas diretas (ex: getDeepestEndLocation) por chamadas a locationManager - Move getDeepestLocation(Node, boolean) para dentro de LocationManager
…stimadas e documentação do projeto, incluindo referências a JFlex solicitadas no requisito
- Introduzida uma função `bad_return_type` com um tipo de retorno inválido em `bad.py`. - Adicionada uma função Fibonacci válida `fib` em `good.py` - Atualizados `bad.py.ast` e `good.py.ast` com arquivos AST correspondentes para ambos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.
Notes for teachers
Use this PR to leave feedback. Here are some tips:
For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @Asunnya