How to Code Review

Things to look for:

• Make sure the author is not "Vagrant" - it should be the actual author.
• Class / method documentation at least.
  • Did they use Doxygen to generate documentation?
• All TODO items must have a name attached to them.
• Big new function = add a unit test.
• Big new feature = add unit tests and integration test (follow example of last years code)
• New source directory (e.g. at the level of rice-namenode or rpcserver) = cc Kevin or Eddie for review
• If a test is added, make sure it's also added to run-all-tests.cc and .ci/main.sh