Skip to content

PDJB-1425: Temp fix emails for org landlords - #1672

Draft
samyou-softwire wants to merge 5 commits into
feat/PDJB-1276-org-landlords-on-property-details-landlords-tabfrom
fix/PDJB-1425-temp-fix-emails-for-org-landlords
Draft

PDJB-1425: Temp fix emails for org landlords#1672
samyou-softwire wants to merge 5 commits into
feat/PDJB-1276-org-landlords-on-property-details-landlords-tabfrom
fix/PDJB-1425-temp-fix-emails-for-org-landlords

Conversation

@samyou-softwire

Copy link
Copy Markdown
Contributor

Ticket number

PDJB-1425

Goal of change

Summary of the problem the PR is trying to solve - usually a 1 sentence summary of the ticket

Description of main change(s)

Summary of the changes made. These should focus on the functionality that you've changed rather than the actual code
changes - those will be clear from the PR.
E.g. Prefer "Adds new endpoint for uploading gas safety certificates to s3" to "Adds new UploadGasSafetyCertificate
controller that accepts a UploadFileRequest and uses the fileUploadService to upload the file to s3"

Anything you'd like to highlight to the reviewer?

Include e.g. anything unusual about the PR, where there was some debate over how to implement it, or anywhere you were
unsure of the approach to take and would like specific feedback.

Checklist

Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done

  • Screenshots of any UI changes have been added
  • Unit tests for new logic (e.g. new service methods) have been added
  • Controller tests for any new endpoints, including testing the relevant permissions
  • Single page integration tests have been added for any unhappy-flow UI features, e.g. validation errors
  • New journey steps have been added to the appropriate journey integration test(s)
  • A new journey integration test has been added for any new journeys
  • New email templates have been added to /src/main/kotlin/resources/emails/emailTemplates.json
  • Test suite has been run in full locally and is passing
  • Branch has been rebased onto main and run locally, with everything working as expected (both for your new feature
    and any related functionality)
  • TODO comments referencing this JIRA ticket have been searched for and removed - if a future PR will address them,
    mention that here
  • Seed data has been updated as needed for your feature to be tested without having to e.g. register a new property
  • NftDataSeeder has been updated to reflect any changes to the database schema
  • Any special release instructions (e.g. the database will need resetting, emails to be added/removed) have been to the relevant release
    ticket on the Jira board, referencing your ticket number
  • QA instructions have been added to the ticket (particularly if this is the last PR required to complete the ticket)
  • This feature is behind a feature flag. I've checked that there will be no change in function if the feature flag is disabled
  • This feature is not behind a feature flag. I've checked that this is appropriate and we're happy with this code becoming live as soon as we release

@samyou-softwire samyou-softwire self-assigned this Jul 31, 2026
@samyou-softwire
samyou-softwire changed the base branch from main to feat/PDJB-1276-org-landlords-on-property-details-landlords-tab July 31, 2026 17:33
@samyou-softwire
samyou-softwire force-pushed the fix/PDJB-1425-temp-fix-emails-for-org-landlords branch 2 times, most recently from 6d9fde9 to 3343af6 Compare July 31, 2026 17:48
@samyou-softwire
samyou-softwire force-pushed the fix/PDJB-1425-temp-fix-emails-for-org-landlords branch from 3343af6 to 09589bb Compare July 31, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant