PDJB-NONE: [EXPERIMENT] Block external analytics requests in integration tests - #1671
Draft
Travis-Softwire wants to merge 8 commits into
Draft
PDJB-NONE: [EXPERIMENT] Block external analytics requests in integration tests#1671Travis-Softwire wants to merge 8 commits into
Travis-Softwire wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment branch — not for merge.
Measuring whether removing the external analytics request from the test critical path speeds up CI.
The layout renders
<script async src="https://plausible.io/js/pa-...js">from a hardcoded constant (PLAUSIBLE_URL), not from the configurableplausible.base-url. So every page load in every integration test makes a real external HTTPS request. Being anasyncscript it delays the windowloadevent, whichClickAndWaitable.clickAndWaitwaits for — putting an internet round trip on the critical path of every interaction. Each test gets a freshBrowserContext, so the browser cache never helps.This branch aborts those requests via
page.route, and temporarily uploadsbuild/test-resultsso each run yields per-class timings rather than one noisy wall-clock number.Control: the reset-only branch measured 21.0 / 22.7 / 21.4 min (mean 21.7) for the
gradle checkstep over three runs of identical code.