PDJB-1276: Org landlords on property details landlords tab - #1667
Conversation
bd8b30f to
00648ce
Compare
this should allow for QA viewing property 1 details
TomHanmer29
left a comment
TomHanmer29
left a comment
There was a problem hiding this comment.
LGTM! Just a couple small thoughts :)
| JOIN property_ownership po ON po.id = 1600 + i | ||
| ON CONFLICT DO NOTHING; | ||
|
|
||
| -- PDJB-1276: Add org landlord (11) as joint landlord on property 1 |
There was a problem hiding this comment.
nit: Do we need to prefix this with the ticket number? Is this a convention we should adopt more widely? I think in general these files are becoming pretty big and hard to follow, but we're talking about them in catchup soon anyway
There was a problem hiding this comment.
yeah I think we should audit this file a bit; I wonder how much of this data was just added for a QA
|
|
||
| assertEquals(2, detailsPage.landlordSummaryCards.size) | ||
| val currentUserCard = detailsPage.landlordSummaryCards[0] | ||
| assertEquals("Alexander Smith (you)", currentUserCard.title.getText()) |
There was a problem hiding this comment.
Can we add one of these to assert the (your organisation) text is working or is that a lot of setup for this PR?
There was a problem hiding this comment.
I'll look into this; not big right now but I can imagine tests down the road will need to test views like this
There was a problem hiding this comment.
okay; the @WithOrgLandlordUser can be applied to an integration test class and will make you be logged in as an org landlord
|
re requesting review on how the org landlord testing infrastructure looks |
|
|
||
| import org.springframework.test.context.ActiveProfiles | ||
|
|
||
| @ActiveProfiles(profiles = ["local", "local-no-auth", "local-org-landlord"]) |
There was a problem hiding this comment.
I think this is a fine way of doing it, it kinda sets the precedent that individual landlords are "normal" (as we have no annotation for them) and org landlords are "special" but I think that's true. The only similar thing to this is the @withMockUser annotation for landlords, LC and SO but I think these are separate enough concepts.
|
waiting on base branch #1654 to merge |
2 participants
Ticket number
PDJB-1276
Goal of change
make it so org landlords show up on the property details list of landlords tab
screenshots
my viewsomeone elses view
Description of main change(s)
Anything you'd like to highlight to the reviewer?
Checklist
Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done
and any related functionality)
mention that here