PDJB-1133: Organisation address lookup - #1610
Conversation
bnjn-mt
changed the title
af60006 to
3d93e50
Compare
…registration Co-authored-by: samyou-softwire <108681823+samyou-softwire@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
e4098f4 to
1517743
Compare
samyou-softwire
left a comment
samyou-softwire
left a comment
There was a problem hiding this comment.
a couple comments
would LGTM but a lot of this is code I drafted up so it feels like I'm marking my own homework 😅
| val yourDetailsStep: YourDetailsStep | ||
| val orgNameStep: OrgNameStep | ||
| val orgAddressStep: OrgAddressStep | ||
| val orgAddressTask: AddressTask |
There was a problem hiding this comment.
this typing feels weaker than expected; can this be an OrgAddressTask?
There was a problem hiding this comment.
this is a forms.yml usage, but maybe it's fine for this shared task
| fun skipToOrgLandlordRegistrationOrgAddressPage(): OrgAddressFormPageLandlordRegistration { | ||
| setJourneyStateInSession(LandlordStateSessionBuilder.beforeOrgAddress().build()) | ||
| navigateToLandlordRegistrationJourneyStep(OrgAddressStep.ROUTE_SEGMENT) | ||
| navigateToLandlordRegistrationJourneyStep("${OrgAddressTask.ORGANISATION_ADDRESS_ROUTE_SEGMENT}/lookup-address") |
There was a problem hiding this comment.
should we be using a hardcoded address here for lookup-address?
| } | ||
|
|
||
| @Test | ||
| fun `submitting without an address line 1 returns the missing address line 1 error`(page: Page) { |
There was a problem hiding this comment.
have we lost these tests for the manual address page?
| ManualAddressFormModel().apply { | ||
| addressLineOne = "1 Example Street" | ||
| townOrCity = "Exampleton" | ||
| val routePrefix = OrgAddressTask.ORGANISATION_ADDRESS_ROUTE_SEGMENT |
There was a problem hiding this comment.
this does seem a little suspicious - is this what other state session builders do for address?
Travis-Softwire
left a comment
Travis-Softwire
left a comment
There was a problem hiding this comment.
LGTM subject to Sammy's comments being addressed (and one from me where I think we can start as we mean to on with migrating message keys) :)
| propertyRegistration: | ||
| fieldSetHeading: What is the property address? | ||
| fieldSetHint: This should be an address within England | ||
| organisationLandlordRegistration: |
There was a problem hiding this comment.
In the interest of incrementally moving towards the message files we want, I wonder if it's worth splitting out the address keys into their own file?
| "fieldSetHint" to "forms.lookupAddress.govBodyMemberRegistration.fieldSetHint", | ||
| ) | ||
|
|
||
| override val selectAddressContentProperties: Map<String, Any?> = emptyMap() |
There was a problem hiding this comment.
We're setting the fieldSetHeading via the journey DSL at the moment, we should move that here instead now that we have it
4 participants
Ticket number
PDJB-1133
Goal of change
Allow organisational landlords to find and select their organisation’s address during registration.
Description of main change(s)
organisation-addressroute.Anything you'd like to highlight to the reviewer?
The
the 2028 cohort renders multi-unit median, p90 and p95 durations down to minutesint test on line 117 in MetricsSinglePageTest will fail locally in this branch. It passes when run with GH actions. There is a fix for it here. This shouldn't block this PR from being merged.Checklist