Feat: Replace toolbar share URL with Wikitext copy action and remove redundant bottom button - #6934
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
✅ Generated APK variants! |
|
The repurposing itself matches what #6901 actually asked for — the issue specifically describes replacing the share URL toolbar button ( One thing worth flagging before merge, though: Might be intentional (maybe wikitext genuinely covers the real use case, and plain-URL-copy wasn't pulling its weight), but worth a maintainer call rather than assuming — happy to help scope keeping both if that's the preference, e.g. wikitext on the repurposed button and plain-link-copy staying as a secondary overflow item. Checked for dangling references from the removals ( |
Description (required)
Fixes #6901
What changes did you make and why?
menu_share_current_imageinMediaDetailPagerFragment.ktto generate and copy the formatted MediaWiki snippet ([[File:...]]) directly to the clipboard instead of sharing an HTTPS URL.fragment_image_detail.xmlmenu item title tocopy_wikicodeand icon tomenu_ic_copy_link_24dp, while removing the duplicatemenu_copy_linkitem.copyWikicodebottom blue button fromfragment_media_detail.xmland removed its associated click listener and unused logic fromMediaDetailFragment.ktto clean up the UI.Tests performed (required)
Tested
ProdDebugonRedmi Note 13 Prowith API level36.[[File:filename|thumb|description]]to clipboard with a confirmation Toast.Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928