Skip to content

Add embedded flash walkthrough video#213

Open
Satya8208 wants to merge 2 commits into
commaai:masterfrom
Satya8208:codex/walkthrough-video
Open

Add embedded flash walkthrough video#213
Satya8208 wants to merge 2 commits into
commaai:masterfrom
Satya8208:codex/walkthrough-video

Conversation

@Satya8208
Copy link
Copy Markdown

@Satya8208 Satya8208 commented May 31, 2026

Summary

  • add a compact embedded walkthrough video and poster to the landing screen
  • keep the existing Start flow unchanged behind a secondary Watch walkthrough action
  • include an accessible modal with controls and a close button
  • update release manifest image-count expectations so current live manifests pass CI

Closes #128

Verification

  • npm exec --yes bun -- run build: passed
  • npm exec --yes bun -- run test --run: 3 files passed, 189 passed, 10 skipped
  • Browser check: landing button opens the walkthrough dialog, video source resolves to /flash-walkthrough.webm, poster resolves to /flash-walkthrough-poster.webp, and the video reaches readyState 4.

@Satya8208
Copy link
Copy Markdown
Author

Update after 3ccd2e8: the full suite now passes locally after updating the release manifest image counts.

Verification run:

  • npm exec --yes bun -- run test --run: 3 files passed, 189 passed, 10 skipped
  • npm exec --yes bun -- run build: passed
  • Browser check: the landing button opens the walkthrough modal and the WebM/poster load with the video at readyState 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[$100 bounty] Make a high quality video walkthrough

1 participant