Skip to content

feat: rebuild component-library using Vite#866

Open
michael-odonovan wants to merge 113 commits into
masterfrom
4973_CL_rebuild
Open

feat: rebuild component-library using Vite#866
michael-odonovan wants to merge 113 commits into
masterfrom
4973_CL_rebuild

Conversation

@michael-odonovan

@michael-odonovan michael-odonovan commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

PR description

What is it doing?

Rebuild using Vite and native React/Javascript functionality.
Moves this repo off dependency on an unmaintained package and updates to React 18.

Why is this required?

Maintenance / Security updates.

link to Jira ticket:

https://comicrelief.atlassian.net/browse/ENG-4973

Quick Checklist:

  • My PR title follows the Conventional Commit spec.

  • I have filled out the PR description as per the template above.

  • I have added tests to cover new or changed behaviour.

  • I have updated any relevant documentation.

Important! - lastly, make sure to squash merge...

@michael-odonovan michael-odonovan changed the title feat: rebuild of component library / import of component-library-26 POC feat: rebuild component-library using Vite May 2, 2026
Comment thread src/components/Molecules/Accordion/Accordion.js
Comment thread src/components/Molecules/ArticleTeaser/ArticleTeaser.js
@AndyEPhipps

Copy link
Copy Markdown
Contributor

Still working my way thru this matey; hoping I'll finish up tomorrow morn

Comment thread src/index.js

@AndyEPhipps AndyEPhipps Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alphabetising here makes the diff impossible to follow now, so I'm gonna just presume it's all okay haha

Comment thread .nvmrc
@@ -1 +1 @@
v16.20.0
v22.22.3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AndyEPhipps AndyEPhipps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight: have gone through the code as much as my sanity will alllow for; gonna do some side-by-side stepping through the built application compared to current one for good measure, just to pre-empt anything else while we can do so in easily insolation.

Did you try boshing this into a local CR install yet, @michael-odonovan ?

@KrupaPammi

Copy link
Copy Markdown
Contributor

@michael-odonovan I started reviewing this, from Playwright POV, config changes and tests are looking good.

But I need to test this branch's changes http://localhost:4173/ manually comparing it with https://cr-component-library.netlify.app/

The first issue I found is the ambient video controls just show a circle without a pause/play button inside.

image

I need to check other components too

@michael-odonovan

Copy link
Copy Markdown
Contributor Author

Aight: have gone through the code as much as my sanity will alllow for; gonna do some side-by-side stepping through the built application compared to current one for good measure, just to pre-empt anything else while we can do so in easily insolation.

Did you try boshing this into a local CR install yet, @michael-odonovan ?

Do we have a way of testing these branches again now?
I have a PR setup and ready:
https://github.com/comicrelief/comicrelief-contentful/pull/2007

@AndyEPhipps

AndyEPhipps commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Aight: have gone through the code as much as my sanity will alllow for; gonna do some side-by-side stepping through the built application compared to current one for good measure, just to pre-empt anything else while we can do so in easily insolation.
Did you try boshing this into a local CR install yet, @michael-odonovan ?

Do we have a way of testing these branches again now? I have a PR setup and ready: comicrelief/comicrelief-contentful#2007

Good point...

As it stands with currrent CL, you can import PR branches, but it'll only work locally; good enough a starting point to start mopping up import issues.

However, the build-pr and post-install scripts I added to the previous CL that did the "make me a dist folder plz" thing, look like they've been it's been removed here.

https://github.com/comicrelief/component-library/blob/master/package.json#L73

Since we don't have the same babel tooling here, this'll need updating to reflect the current build commands; will hopefully be very straightforward; just need to stick it in a post-install script directly (or as 'sub-script' like I did with with build-pr).

@AndyEPhipps

Copy link
Copy Markdown
Contributor

Yeha, I saw seeing issues with icons too, think that 'mock.asset' thing is likely the cause; don't fully understand what that is or how its supposed to be used yet, but will pick over it next week.

Review list so far, just in case it's useful, will add to this later:

  • Ambient Video missing play/pause icon missing
  • Checkbox icon missing
  • Input example formatting/layout (not a big deal, can totally be done later in another PR)
  • Select icon missing
  • Select background colour changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants