Fix required validation for hidden fields with depends_on conditions#462
Open
fabiSwDevBeg wants to merge 1 commit into
Open
Fix required validation for hidden fields with depends_on conditions#462fabiSwDevBeg wants to merge 1 commit into
fabiSwDevBeg wants to merge 1 commit into
Conversation
This commit updates EasyFormForm.extractData to properly handle fields with depends_on conditions (PatternSlLib-style). Implements evaluate_dependson() to evaluate the depends_on condition of a field. Adds remove_required() which removes the required flag from fields whose depends_on condition is not satisfied (i.e., hidden fields). Overrides extractData() to apply remove_required() to all form widgets and group widgets before validation. Effect: Hidden fields that are marked as required no longer trigger validation errors, allowing the form to submit successfully when the conditions for showing the field are not met.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates EasyFormForm.extractData to properly handle fields with depends_on conditions (PatternSlLib-style).
Implements evaluate_dependson() to evaluate the depends_on condition of a field.
Adds remove_required() which removes the required flag from fields whose depends_on condition is not satisfied (i.e., hidden fields).
Overrides extractData() to apply remove_required() to all form widgets and group widgets before validation.
Effect:
Hidden fields that are marked as required no longer trigger validation errors, allowing the form to submit successfully when the conditions for showing the field are not met.
Fixes #461