fix encoding issues when using umlauts in from/to headers#405
Open
MrTango wants to merge 2 commits into
Open
Conversation
petschki
previously requested changes
May 16, 2023
petschki
left a comment
Member
There was a problem hiding this comment.
I'd use plone.base.utils.safe_bytes instead.
And the import at the top should be changed to plone.base.utils.safe_text
b2654ad to
db6dbf0
Compare
Requested changes have been made.
db6dbf0 to
c858d53
Compare
Member
|
I rebased on master and force-pushed. |
Member
|
Lots of test failures like this: |
Member
|
@MrTango I don't know why no tests show up here. But locally lots of tests fail like this: I wonder if on Python 3 these headers need to be passed in as strings (text) anyway now... |
c858d53 to
6826fe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.