Prevent "Saved data" view from raising an exception if a field is not found#382
Open
frapell wants to merge 1 commit into
Open
Prevent "Saved data" view from raising an exception if a field is not found#382frapell wants to merge 1 commit into
frapell wants to merge 1 commit into
Conversation
fredvd
requested changes
Dec 14, 2022
Member
There was a problem hiding this comment.
@frapell Looks good to me. But can we add a test for this? I think we can just duplicate the test linked below and add a "stalefield" to the test at saver.showFields = assignment. With your fix it should no longer crash.
collective.easyform/src/collective/easyform/tests/testSaver.py
Lines 137 to 162 in 5251149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes gh-381