feat: add event parameter ordering#26
Open
abdulla-cb wants to merge 2 commits into
Open
Conversation
abdulla-cb
commented
Sep 9, 2024
abdulla-cb
commented
- add rule about ordering event parameters
Collaborator
✅ Heimdall Review Status
|
wilsoncusack
reviewed
Sep 9, 2024
| event UpdatedOwner(address newOwner); | ||
| ``` | ||
|
|
||
| ##### C. Order event parameters in chronological order. |
Contributor
There was a problem hiding this comment.
I think "chronological" could be confusing 🤔 . Might make more sense to say like, "Events logging updated values should follow the convention: previous, new
Author
There was a problem hiding this comment.
yeah I agree I think it's confusing, I've just updated it - thanks
stevieraykatz
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.