docs(release): retract a false claim I made about the release shipping a console build - #36
Open
Jphilbrick10 wants to merge 1 commit into
Open
docs(release): retract a false claim I made about the release shipping a console build#36Jphilbrick10 wants to merge 1 commit into
Jphilbrick10 wants to merge 1 commit into
Conversation
…g a console build
I said `release.yml` omitting `--gui` shipped the developer build to users, and put that in
a commit message, a PR description, a capability-atlas card and a release tag.
It is not true. `build_binary.py` declares:
parser.add_argument("--gui", action="store_true", default=True, ...)
parser.add_argument("--console", dest="gui", action="store_false", ...)
`--gui` is the DEFAULT. I read the flag's USE -- `console_flag = "--windowed" if args.gui
...` -- and never read its DEFAULT six lines below.
MEASURED, not argued: the published v0.21.0 Windows binary has PE Subsystem 2 (GUI, no
console), read straight out of the artifact. The macOS job has always produced a real
`one-link.app`, which is why the matrix's `bundle_path: dist/one-link.app` has worked since
before v0.21.0.
There was a signal I explained away. Under my story, v0.21.0's macOS job should have failed
looking for a `.app` that no `--gui`-less build would produce. It passed. I noticed that
contradiction, filed it as archaeology, and kept going -- instead of letting it kill the
hypothesis, which is what it was.
The console window was real. It came from a desktop shortcut invoking `python.exe` instead
of `pythonw.exe` -- per machine, not per release. Right symptom, right fix for the user,
wrong story about the product.
`--gui` stays, explicitly: it is a no-op, and naming the intent beats depending on a default
I demonstrably misread. The comment now says that instead of claiming a fix.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I said
release.ymlomitting--guishipped the developer build to users, and put that in a commit message, a PR description, a capability-atlas card, and a release tag.It is not true.
--guiis the default. I read the flag's use —console_flag = "--windowed" if args.gui …— and never read its default six lines below.Measured, not argued
The published v0.21.0 Windows binary has PE Subsystem 2 (GUI, no console), read straight out of the artifact:
And the macOS job has always produced a real
one-link.app— which is why the matrix'sbundle_path: dist/one-link.apphas worked since before v0.21.0.I explained away the evidence that would have caught it
Under my story, v0.21.0's macOS job should have failed looking for a
.appno--gui-less build would produce. It passed. I noticed that contradiction, filed it as "archaeology", and kept going — instead of letting it kill the hypothesis, which is what it was.What was actually wrong
The console window was real. It came from a desktop shortcut invoking
python.exeinstead ofpythonw.exe— per machine, not per release. Right symptom, right fix for the user, wrong story about the product.--guistays, explicitly: it's a no-op, and naming the intent beats depending on a default I demonstrably misread. The comment now says that rather than claiming a fix.Everything else from that PR stands on its own — the frameless window chrome, and separately the
dr_test.htmlrelease blocker, which was independently real.🤖 Generated with Claude Code