Fix duplicate augroup END on CR#162
Open
mmrwoods wants to merge 1 commit into
Open
Conversation
9e59ee9 to
e265948
Compare
Contributor
Author
|
Hi @cohama, just wondering if you have any thoughts on this (and the other two PRs I submitted a while ago). I can wrap them all into one PR if you would prefer. If you have any questions please let me know. Thanks |
Owner
|
Thank you for your pull requests. I prefer several small pull requests to one large pull request. I have a question about this PR. What do you mean by “duplicate”? Did you encounter any issues with the augroup? I tried to reproduce the issue, but I could not. |
Contributor
Author
|
At the end of a line containing I realise it is an edge case, but I have occasionally found myself hitting EDIT: see screen recording showing issue Screen.Recording.2026-07-11.at.08.49.39.mov |
Add negative lookahead to pattern and avoid matching augroup END
e265948 to
270c613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @cohama,
When editing vimscript files if you enter
<CR>afteraugroup ENDa duplicateaugroup ENDis added.I've updated the pattern to address this, by adding a negative lookahead to not match
augroup END.Hope this is useful :-)