meta-PR#4
Open
pschmitt wants to merge 6 commits into
Open
Conversation
- Implement a guess_domain function that will return the first custom domain (or the first sandboxed one if sanbox is set to True). - MailgunCredentialsError is now raised by the __request function. - The domain name, if provided, is now checked against the list of available domain. If it is invalid a MailgunDomainError is raised. - A caching system has been implemented. If use_cache is set to True, any call to __request will first check if the same request has already been issued and return its results without making an actual API call, thus preventing multiple calls to the GET /domains endpoint when initializing the client.
Valentin-Foucher
force-pushed
the
master
branch
from
285b54a to
2eb89e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR encompasses all my work I have doing on pymailgun.
It includes the changes from #1 #2 and #3, plus a few extras: