Skip to content

fix: add default value for non-nullable field with default value that needs alias#643

Open
MortGron wants to merge 2 commits into
mainfrom
add-default-value-for-non-nullable-field-with-alias
Open

fix: add default value for non-nullable field with default value that needs alias#643
MortGron wants to merge 2 commits into
mainfrom
add-default-value-for-non-nullable-field-with-alias

Conversation

@MortGron
Copy link
Copy Markdown
Contributor

@MortGron MortGron commented May 9, 2026

Description

Reviewer: All code inside examples/ is generated.

Non-nullable fields with default value that needed an alias would not have the default value set in the generated SDK. This is now fixed.

Bump

  • Patch
  • Minor
  • Skip

Changelog

Fixed

  • Default value is now set in the generated data classes for non-nullable fields that needs an alias.

@MortGron MortGron requested review from a team as code owners May 9, 2026 09:50
@gemini-code-assist
Copy link
Copy Markdown

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@doctrino doctrino added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label May 11, 2026
@thorkildcognite
Copy link
Copy Markdown

@MortGron Looks like this is consistently failing builds? (I retrigger to check). Could you please fix that so it can go through risk review?

@MortGron
Copy link
Copy Markdown
Contributor Author

@MortGron Looks like this is consistently failing builds? (I retrigger to check). Could you please fix that so it can go through risk review?

@thorkildcognite The build/coverage action runs the integration tests. This I cannot fix because I do not have access to the CDF project where the integration tests are: python-pygen. See also this https://cognitedata.slack.com/archives/C050CEHKNB1/p1778412654797489

The two other build tests seems to fail in all PRs, also the ones made by renovate bot, so that problem seems to be a general one not relating to this PR

@thorkildcognite
Copy link
Copy Markdown

@doctrino Could you assist @MortGron here to resolve the build issues?

@haakonvt
Copy link
Copy Markdown
Contributor

@doctrino Could you assist @MortGron here to resolve the build issues?

@thorkildcognite Anders is on parental leave, lets ask @ronpal instead

@ronpal
Copy link
Copy Markdown
Contributor

ronpal commented May 13, 2026

@doctrino Could you assist @MortGron here to resolve the build issues?

@thorkildcognite Anders is on parental leave, lets ask @ronpal instead

On it!

@thorkildcognite thorkildcognite added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels May 14, 2026
@thorkildcognite
Copy link
Copy Markdown

Sending it back to the team for fixes. Assign it back when things are building as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants