Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 5 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 5 commits into
cognis-digital wants to merge 5 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 3 unused import(s) (ruff F401/F811)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cognis-digital
force-pushed
the
cognis-audit/repo-hardening
branch
from
9cfd51d to
71471ee
Compare
…-06-13) - README install instructions point at the working git+https path - ran the actual audit: 12 tests passed, 0 parse errors, CLI C:\Python314\python.exe: No module named https - embedded results in README ## Verification and AUDIT.md
- layman.md: plain-English description of what leadforge does (CRM pipeline with email sequences) - README.md: insert "What is this?" section with layman description; insert managed Install block with pipx/uv/pip/source instructions - install.sh: comprehensive POSIX installer (pipx -> uv -> pip -> source) - install.ps1: comprehensive Windows PowerShell installer (same methods)
- core._load: wrap json.load + Lead(**rec) in LeadForgeError with clear messages; reject non-dict top-level; drop unknown keys for forward-compatibility; guard sequences field type - core.save: wrap OSError -> LeadForgeError - core.add_lead: strip/validate name, reject negative/non-numeric value - core.due_steps: skip leads whose sequence was removed (avoids KeyError) - cli.main: catch bare Exception -> exit 2 with JSON error to stderr - mcp_server: fix dead scan/to_json imports; expose pipeline() instead; wrap errors in LeadForgeError handler - tests: 11 new tests covering corrupt DB, invalid inputs, empty results, orphaned sequence, mcp_server import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.