Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 4 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 4 commits into
cognis-digital wants to merge 4 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 5 unused import(s) (ruff F401/F811)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cognis-digital
force-pushed
the
cognis-audit/repo-hardening
branch
from
c20c43d to
03b713d
Compare
added 3 commits
June 13, 2026 03:52
…nstall instructions Move --format from root parser to each subcommand (diff/apply) so that 'crmsync diff file.csv --format json' works as documented. Previously the flag was silently unreachable after a subcommand name, causing test_cli_json_format to fail with SystemExit 2. All 10 tests now pass. Also insert a plain-language "What is this?" section in README and comprehensive install scripts (install.sh, install.ps1).
- cli.py: wrap apply_plan() call with sqlite3.Error/ValueError handler so write failures (read-only DB, disk full, etc.) print a clean error to stderr and return exit code 2 instead of raising an unhandled traceback - mcp_server.py: move scan/to_json import inside serve() so the module imports cleanly; broken top-level import previously caused ImportError on any code path that loaded the module - tests/test_hardening.py: 6 new tests covering missing export file (rc=2), malformed JSON (rc=2), missing key column (rc=2), apply write failure (rc=2), empty export (no drift), and mcp_server clean import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.