Skip to content

chore(cmd): change table label #272

Merged
vincenzopalazzo merged 2 commits into
coffee-tools:macros/moving-repository-dirfrom
Anyitechs:change-table-label
May 15, 2024
Merged

chore(cmd): change table label #272
vincenzopalazzo merged 2 commits into
coffee-tools:macros/moving-repository-dirfrom
Anyitechs:change-table-label

Conversation

@Anyitechs

Copy link
Copy Markdown

This PR addresses @tareknaser and @vincenzopalazzo suggestion in #239 (comment)

Closes #268

@vincenzopalazzo

Copy link
Copy Markdown
Contributor

Coffee has the best documentation that I ever written, please read the commit style https://coffee-docs.netlify.app/contributing-to-coffee

@tareknaser tareknaser left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread coffee_cmd/src/coffee_term/command_show.rs Outdated

@vincenzopalazzo vincenzopalazzo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing is hard in coding, and it is naming things 😄

After that ping me and we merge the PR

term::format::dim(String::from("●")),
term::format::bold(String::from("Defects")),
term::format::bold(String::from("Affected repositories")),
term::format::bold(String::from("Action")),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
term::format::bold(String::from("Action")),
term::format::bold(String::from("Affected")),

thanks @tareknaser for the suggestion

@Anyitechs Anyitechs changed the title chore(change-table-label): change table label from "Affected repositories" to "Action" chore(cmd): change table label Apr 18, 2024
@Anyitechs

Copy link
Copy Markdown
Author

Coffee has the best documentation that I ever written, please read the commit style https://coffee-docs.netlify.app/contributing-to-coffee

Thank you @vincenzopalazzo for sharing the link. Recent commits are following the style guide now.

@vincenzopalazzo vincenzopalazzo merged commit 8615159 into coffee-tools:macros/moving-repository-dir May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants