[Test Improver] Add unit tests for useDragHandler composable - #100
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Test Improver] Add unit tests for useDragHandler composable#100github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
31 unit tests covering the drag-and-drop tab composable: - initial state (dragOverPositionsActive, dragOverTabBarActive, pinArea) - lockedPositions computed — store state passthrough - lockedPosition computed — position membership check - pin computed getter/setter (CENTER guard on commit) - onDragPositionStart — dataTransfer encoding, shared flags - onDragPositionOver — pinArea update, conditional preventDefault - onDragPositionEnd — setUserPin, switchTab, flag reset - onTabBarDragOver / onTabBarDragLeave — dragOverTabBarActive toggle - onTabBarDrop — commit wm/switchTab, missing-data warn path - shared module-level refs verified across instances Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Test Improver, an automated AI assistant focused on improving test coverage.
Goal and Rationale
shell/components/nav/WindowManager/composables/useDragHandler.tshandles all drag-and-drop tab positioning in the Window Manager — a critical interactive feature. It had zero test coverage. The composable has real branching logic (CENTER guards, shared module-level state, dataTransfer encoding) that benefits from targeted testing.Approach
vuex(useStore) to return a controllable store withstate.wm.lockedPositionsandstate.wm.userPinmakeDragEventhelper to simulateDragEventwithdataTransferandpreventDefaultmocksdragOverPositionsActive,pinArea) inbeforeEachto prevent test pollutiondragOverPositionsActiveandpinArearefs)Tests (31 total)
Coverage Impact
The composable was previously untested (0% coverage). After this PR it reaches 100% statement/branch/function coverage for
useDragHandler.ts.Test Status
✅ 31/31 tests pass (
yarn test:ci --testPathPattern=useDragHandler)✅ ESLint clean (
eslint --max-warnings 0)Reproducibility
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
download.cypress.ioSee Network Configuration for more information.